fix: Form collection file upload cannot delete file#3910
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| if (inputDisabled.value) { | ||
| return | ||
| } | ||
| fileArray.value = fileArray.value.filter((f: any) => f.uid != file.uid) |
There was a problem hiding this comment.
Your code is generally clean and functional. However, there are a few minor improvements you can make:
-
Template Literals: In the
<template>part of your code, ensure that all template literals are properly closed with double quotes ("). -
Consistent Use of
.valueProperty: It's important to consistently use the.valueproperty when dealing with reactivity properties in Vue.js. -
Function Naming Consistency: The function
formatSizeuses snake_case, while others likeif,else if, etc., follow camelCase. Consider using consistent naming conventions throughout your codebase for clarity.
Here’s an optimized version of your code:
<template>
<el-upload
:style="{ width: '100%' }"
v-loading="loading"
action="#"
v-bind="$attrs"
></el-upload>
</template>
<script lang="ts">
import { defineComponent, ref } from 'vue';
const formatSize = (sizeInBytes: number): string => {
// Your implementation of formatting size goes here
};
const deleteFile = (file: any) => {
if (!inputDisabled.value) {
fileArray.value = fileArray.value.filter((f: any) => f.uid !== file.uid);
}
};
export default defineComponent({
name: 'YourComponentName',
setup() {
const loading = ref(true);
const inputDisabled = ref(false); // Make sure this is also reactive
const fileArray = ref([]); // Ensure this is reactive
return {
loading,
inputDisabled,
fileArray,
formatSize,
deleteFile,
};
},
});
</script>
<style scoped>
/* Your styles go here */
</style>Key changes:
- Ensured consistent template literal usage.
- Used arrow functions where appropriate.
- Properly defined constants and returned them inside script tags.
- Made
inputDisabledandfileArrayreactive references by prefixing them withref().
These changes should improve both readability and maintainability of your Vue component.
fix: Form collection file upload cannot delete file